Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add pagination to storageGC page #376

Merged
merged 3 commits into from
Jan 24, 2025
Merged

add pagination to storageGC page #376

merged 3 commits into from
Jan 24, 2025

Conversation

LexLuthr
Copy link
Contributor

@LexLuthr LexLuthr commented Jan 21, 2025

Without filters

Screenshot 2025-01-22 at 1 17 47 PM

With Filters

Screenshot 2025-01-22 at 1 29 56 PM

Without pagination, we end up with page refusing to load where GC number is large.
image (13)

@LexLuthr LexLuthr requested a review from magik6k January 21, 2025 07:09
Copy link
Collaborator

@magik6k magik6k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pagination means that it's harder to ctrl-f a given thing.

I'd at least add filters like:

  • SP ID checkboxes
  • File type checkboxes
  • Maybe a "find sector number" input

@LexLuthr LexLuthr force-pushed the storageGC-pagination branch from 09e4ae7 to c440602 Compare January 22, 2025 04:25
@LexLuthr LexLuthr requested review from magik6k and snadrus January 22, 2025 11:04
@magik6k magik6k merged commit 2347010 into main Jan 24, 2025
29 checks passed
@magik6k magik6k deleted the storageGC-pagination branch January 24, 2025 09:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants